Update Python support for 3.13 #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glatterf42
added
enh
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
=====================================
Coverage 95.5% 95.6%
=====================================
Files 46 46
Lines 4340 4335 -5
=====================================
- Hits 4148 4147 -1
+ Misses 192 188 -4
|
glatterf42
force-pushed
the
enh/support-python3.13
branch
from
7e9d42b to
10b9e8d
Compare
khaeru
force-pushed
the
enh/support-python3.13
branch
from
10b9e8d to
84899f8
Compare
|
Rebased with the completion of #544. If there are no obstacles, we can update this with parallel improvements to the others made on that branch. |
khaeru
force-pushed
the
enh/support-python3.13
branch
from
84899f8 to
9ba20da
Compare
khaeru
added a commit
that referenced
this pull request
Nov 20, 2024
khaeru
force-pushed
the
enh/support-python3.13
branch
from
9ba20da to
89abcfc
Compare
- Use macos-13 for Python 3.9. - Use macos-latest for Python 3.10–3.13. - Parallel iiasa/ixmp#532
khaeru
added a commit
that referenced
this pull request
Nov 20, 2024
khaeru
force-pushed
the
enh/support-python3.13
branch
from
89abcfc to
78b1291
Compare
Import of these from `typing` is deprecated from Python 3.9.
khaeru
force-pushed
the
enh/support-python3.13
branch
from
78b1291 to
19d20d1
Compare
khaeru
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
@glatterf42 I leave this approval so that merging is un-blocked, but please let me know if we should discuss any of the later commits I added to the branch.
9 tasks
|
Thanks for finishing this, I don't think we need to discuss any commits here :) |
|
Please do the honours 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @khaeru in #880, we should drop support for the now outdated version 3.8 of Python and add support for the new 3.13. This PR does just that.
Please also see the analogous iiasa/ixmp#544, which details some issues that need to be closed upstream before we can support 3.13.
How to review
PR checklist